Refactor email configuration handling and improve logging for email delivery

Web/modules/database/settings.py

@@ -220,13 +220,25 @@ SSL_CERT = _get(_conf, ['ssl', 'cert'], DEFAULTS['ssl']['cert'])
 SSL_KEY = _get(_conf, ['ssl', 'key'], DEFAULTS['ssl']['key'])
 
 # Email settings
-EMAIL_ENABLED = bool(os.getenv('EMAIL_ENABLED', False))
-EMAIL_SMTP_HOST = str(os.getenv('EMAIL_SMTP_HOST', False))
+def _get_email_env(name, default=''):
+    value = os.getenv(name)
+    if value is None:
+        return default
+    value = value.strip()
+    return '' if value.lower() in {'', 'false', 'none', 'null'} else value
+
+
+EMAIL_ENABLED = _get_email_env('EMAIL_ENABLED').lower() in {'1', 'true', 'yes', 'on'}
+EMAIL_SMTP_HOST = _get_email_env('EMAIL_SMTP_HOST')
 EMAIL_SMTP_PORT = int(os.getenv('EMAIL_SMTP_PORT', 587))
 EMAIL_USE_TLS = True
-EMAIL_USERNAME = str(os.getenv('EMAIL_USERNAME', False))
-EMAIL_PASSWORD = str(os.getenv('EMAIL_PASSWORD', False))
-EMAIL_FROM_ADDRESS = _get(_conf, ['email', 'from_address'], EMAIL_USERNAME)
+EMAIL_USERNAME = _get_email_env('EMAIL_USERNAME')
+EMAIL_PASSWORD = _get_email_env('EMAIL_PASSWORD')
+EMAIL_FROM_ADDRESS = (
+    _get_email_env('EMAIL_FROM_ADDRESS')
+    or _get(_conf, ['email', 'from_address'], '')
+    or EMAIL_USERNAME
+)
 EMAIL_DEFAULT_SENDER_NAME = "Invario Inventarsystem Sender"
 EMAIL_TIMEOUT_SECONDS = 20