fix of wrong Registry keys

.github/workflows/release-docker.yml

@@ -1,4 +1,4 @@
-name: https://github.com/AIIrondev/legendary-octo-garbanzo
+name: Release Inventarsystem
 
 on:
   push:
@@ -25,6 +25,7 @@ env:
 
 jobs:
   release-docker:
+    # Hinweis: Falls dein lokaler Gitea-Runner ein anderes Label hat (z.B. 'linux' oder 'self-hosted'), passe dies hier an.
     runs-on: ubuntu-latest
 
     steps:
@@ -34,18 +35,20 @@ jobs:
       - name: Set metadata
         id: meta
         env:
+          # Gitea stellt das GITHUB_TOKEN für Kompatibilität mit GitHub Actions automatisch zur Verfügung
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          REPO: ${{ github.repository }}
+          REPO: ${{ gitea.repository }}
-          EVENT_NAME: ${{ github.event_name }}
+          EVENT_NAME: ${{ gitea.event_name }}
-          REF_NAME: ${{ github.ref_name }}
+          REF_NAME: ${{ gitea.ref_name }}
-          BUMP_TYPE: ${{ github.event.inputs.bump || 'patch' }}
+          BUMP_TYPE: ${{ gitea.event.inputs.bump || 'patch' }}
+          DOCKER_API_VERSION: '1.44'
         run: |
           if [ "$EVENT_NAME" = "push" ] && [ -n "$REF_NAME" ]; then
             TAG="$REF_NAME"
           else
-            # Fetch latest release tag via GitHub API (fall back to v0.8.31)
+            # Gitea API Endpunkt nutzen, um das aktuellste Release abzufragen
             latest_tag="v0.8.31"
-            if meta_json=$(curl -fsSL -H "Authorization: Bearer $GH_TOKEN" -H "Accept: application/vnd.github+json" "https://api.github.com/repos/$REPO/releases/latest" 2>/dev/null); then
+            if meta_json=$(curl -fsSL -H "Authorization: Bearer $GH_TOKEN" -H "Accept: application/json" "https://git.invario-software.eu/api/v1/repos/$REPO/releases/latest" 2>/dev/null); then
               tag_name=$(printf "%s" "$meta_json" | sed -n 's/.*"tag_name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p' | head -n1)
               if [ -n "$tag_name" ]; then
                 latest_tag="$tag_name"
@@ -108,19 +111,58 @@ jobs:
             TAG="${base}.${i}"
           fi
 
-          IMAGE="ghcr.io/aiirondev/legendary-octo-garbanzo:${TAG}"
+          # Docker Images verlangen Kleinbuchstaben. Repository-Namen daher umwandeln.
+          LOWER_REPO=$(echo "$REPO" | tr '[:upper:]' '[:lower:]')
+          IMAGE="git.invario-software.eu/${LOWER_REPO}:${TAG}"
+          
           echo "tag=$TAG" >> "$GITHUB_OUTPUT"
           echo "image=$IMAGE" >> "$GITHUB_OUTPUT"
+          echo "lower_repo=$LOWER_REPO" >> "$GITHUB_OUTPUT"
+
+      - name: Ensure Docker CLI is available and up to date
+        run: |
+          install_docker=true
+          
+          # Prüfen, ob Docker existiert und ob die Version ausreicht
+          if command -v docker >/dev/null 2>&1; then
+            # Extrahiere die Major-Version (z. B. "20" aus "20.10.24" oder "26" aus "26.1.0")
+            DOCKER_MAJOR=$(docker --version | grep -oE '[0-9]+' | head -n1)
+            
+            # API 1.44 erfordert mindestens Docker v25
+            if [ -n "$DOCKER_MAJOR" ] && [ "$DOCKER_MAJOR" -ge 25 ]; then
+              install_docker=false
+            fi
+          fi
+
+          if [ "$install_docker" = true ]; then
+            echo "Veraltete oder fehlende Docker-Installation erkannt. Führe Update durch..."
+            if command -v apt-get >/dev/null 2>&1; then
+              apt-get update
+              DEBIAN_FRONTEND=noninteractive apt-get install -y curl
+              # Nutzt das offizielle Docker-Skript (installiert docker-ce statt das alte docker.io)
+              curl -fsSL https://get.docker.com | sh
+            elif command -v apk >/dev/null 2>&1; then
+              apk update
+              apk add --no-cache docker-cli
+            else
+              echo "Error: no supported package manager found to install docker"
+              exit 1
+            fi
+          else
+            echo "Docker CLI ist bereits auf einem aktuellen Stand."
+          fi
+
+          docker --version
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
-      - name: Login to GHCR
+      - name: Login to Gitea Container Registry
         uses: docker/login-action@v3
         with:
-          registry: ghcr.io
+          registry: git.invario-software.eu
-          username: ${{ github.actor }}
+          username: ${{ gitea.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
+          password: ${{ secrets.REGISTRY_TOKEN }}
 
       - name: Build and push release image
         uses: docker/build-push-action@v6
@@ -128,10 +170,10 @@ jobs:
           context: .
           file: ./Dockerfile
           push: true
-          load: true # Lädt das Image in den lokalen Docker-Daemon für den 'docker save' Schritt
+          # 'load: true' wurde entfernt, um API-Version-Mismatches mit dem Host-Daemon zu verhindern
           tags: |
             ${{ steps.meta.outputs.image }}
-            ghcr.io/aiirondev/legendary-octo-garbanzo:latest
+            git.invario-software.eu/${{ steps.meta.outputs.lower_repo }}:latest
 
       - name: Build local image tar for offline deploy
         run: |
@@ -139,20 +181,10 @@ jobs:
           IMG="${{ steps.meta.outputs.image }}"
           TAG="${{ steps.meta.outputs.tag }}"
 
-          if docker image inspect "$IMG" >/dev/null 2>&1; then
+          echo "Pulling freshly pushed image from registry: $IMG"
-            echo "Using local image $IMG"
+          docker pull "$IMG"
-            docker save "$IMG" | gzip > "inventarsystem-image-${TAG}.tar.gz"
-            exit 0
-          fi
 
-          echo "Local image $IMG not found, trying to pull"
+          echo "Saving image to offline tar archive..."
-          if docker pull "$IMG" >/dev/null 2>&1; then
-            docker save "$IMG" | gzip > "inventarsystem-image-${TAG}.tar.gz"
-            exit 0
-          fi
-
-          echo "Pull failed, attempting local docker build as fallback"
-          docker build -t "$IMG" .
           docker save "$IMG" | gzip > "inventarsystem-image-${TAG}.tar.gz"
 
       - name: Create release-only docker bundle
@@ -161,7 +193,7 @@ jobs:
           cat > release-bundle/docker-compose.yml <<EOF
           services:
             app:
-              image: \${INVENTAR_APP_IMAGE:-ghcr.io/aiirondev/legendary-octo-garbanzo:${{ steps.meta.outputs.tag }}}
+              image: \${INVENTAR_APP_IMAGE:-${{ steps.meta.outputs.image }}}
               container_name: inventarsystem-app
               restart: unless-stopped
               ports:
@@ -242,7 +274,7 @@ jobs:
           find release-bundle -maxdepth 1 -type f -name '*.sh' -exec chmod +x {} \; || true
           tar -czf inventarsystem-docker-bundle.tar.gz -C release-bundle .
 
-      - name: Create or update GitHub Release
+      - name: Create or update Gitea Release
         uses: softprops/action-gh-release@v2
         with:
           tag_name: ${{ steps.meta.outputs.tag }}

Web/app.py

@@ -42,6 +42,7 @@ import Web.modules.database.termine as termin
 import Web.modules.log.audit_log as al
 import push_notifications as pn
 import Web.modules.inventarsystem.pdf_export as pdf_export 
+import Web.modules.inventarsystem.excel_export as excel_export
 import datetime
 from apscheduler.schedulers.background import BackgroundScheduler
 from bson.objectid import ObjectId
@@ -288,7 +289,7 @@ SCHEDULER_INTERVAL = cfg.SCHEDULER_INTERVAL_MIN
 SSL_CERT = cfg.SSL_CERT
 SSL_KEY = cfg.SSL_KEY
 
-LIBRARY_ITEM_TYPES = ['book', 'cd', 'dvd', 'media', 'schulbuch']
+LIBRARY_ITEM_TYPES = ('book', 'cd', 'dvd', 'other', 'schoolbook', 'Buch', 'Schulbuch', 'schulbuch')
 INVOICE_CURRENCY = 'EUR'
 
 NOTIFICATION_STATUS_CACHE_TTL = max(3, int(os.getenv('INVENTAR_NOTIFICATION_STATUS_CACHE_TTL', '8')))
@@ -2476,6 +2477,7 @@ def _upload_excel_items(scope='inventory'):
                 parent_item_id=parent_item_id,
                 isbn=row['isbn'],
                 item_type=row['item_type'],
+                is_library=False
             )
             if not item_id:
                 import_errors.append((row['row_number'], 'Fehler beim Anlegen des Artikels'))
@@ -2979,33 +2981,50 @@ def library_export_excel(scope='all'):
     username = session['username']
     is_admin_user = us.check_admin(username)
     
-    import Web.modules.inventarsystem.excel_export as excel_export
+    # Base query
-    client = MongoClient(MONGODB_HOST, MONGODB_PORT)
+    query = {
-    db = client[cfg.MONGODB_DB]
+        'ItemType': {'$in': LIBRARY_ITEM_TYPES}, 
-    items_collection = db['items']
+        'Deleted': {'$ne': True}
-    
+    }
-    query = {'ItemType': {'$in': LIBRARY_ITEM_TYPES}, 'Deleted': {'$ne': True}}
     
+    # Scope modifications
     if scope == 'borrowed_by_me':
         query['User'] = username
         query['Verfuegbar'] = False
         filename = f"Bibliothek_Ausgeliehen_{username}.xlsx"
+        
     elif scope == 'all_borrowed':
         if not is_admin_user:
+            # Consider adding a flash message here before redirecting
             return redirect('/library')
         query['Verfuegbar'] = False
         filename = "Bibliothek_Alle_Ausleihen.xlsx"
+        
     elif scope == 'schulbuecher':
+        # Overwrites the base $in query, which is fine
         query['ItemType'] = 'schulbuch'
         filename = "Schulbuecher_Bestand.xlsx"
+        
+    elif scope == 'all_books':
+        # FIX: Keep the library item types restriction, but exclude 'general'
+        query['ItemType'] = {'$in': [t for t in LIBRARY_ITEM_TYPES if t != 'general']}
+        filename = "Bibliothek_Buecher.xlsx"
+        
     else:
-        # 'all'
+        # 'all' scope
         filename = "Bibliothek_Gesamtbestand.xlsx"
         
+    # Database interaction
+    client = MongoClient(MONGODB_HOST, MONGODB_PORT)
+    db = client[cfg.MONGODB_DB]
+    items_collection = db['items']
+    
     items = list(items_collection.find(query))
     client.close()
     
+    # Generate and send file
     excel_file = excel_export.generate_library_excel(items)
+    
     return send_file(
         excel_file,
         mimetype='application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
@@ -3193,7 +3212,7 @@ def api_library_items():
         ausleihungen_db = db['ausleihungen']
 
         query = {
-            'ItemType': {'$in': ['book', 'cd', 'dvd', 'media']},
+            'ItemType': {'$in': ['book', 'cd', 'dvd', 'other', 'schoolbook', 'schulbuch', 'Buch', 'Schulbuch']},
             'IsGroupedSubItem': {'$ne': True},
             'Deleted': {'$ne': True}
         }
@@ -5115,6 +5134,8 @@ def upload_item():
     if 'username' not in session:
         return jsonify({'success': False, 'message': 'Nicht angemeldet'}), 401
         
+    item_is_library = False
+
     # Check if user may insert items
     username = session['username']
     permissions = _get_current_user_permissions() or us.build_default_permission_payload('standard_user')
@@ -5159,6 +5180,9 @@ def upload_item():
         item_type_input = sanitize_form_value(request.form.get('item_type_input', ''))
         library_category = sanitize_form_value(request.form.get('library_category', ''))
         
+        if library_category != '':
+            item_is_library = True
+
         try:
             item_count = int(item_count_raw) if item_count_raw else 1
         except (TypeError, ValueError):
@@ -5227,7 +5251,7 @@ def upload_item():
             return redirect(url_for(success_redirect_endpoint))
 
     item_isbn = ''
-    item_type = 'general'
+    item_type = 'other'
     if cfg.MODULES.is_enabled('library') and isbn_raw:
         normalized_isbn = normalize_and_validate_isbn(isbn_raw)
         if normalized_isbn:
@@ -5235,8 +5259,7 @@ def upload_item():
             item_type = 'book'
         else:
             item_isbn = isbn_raw
-            if upload_mode == 'library':
+
-                item_type = 'book'
         if item_type_input != "":
             item_type = item_type_input
 
@@ -5253,7 +5276,6 @@ def upload_item():
                 return jsonify({'success': False, 'message': error_msg}), 400
             flash(error_msg, 'error')
             return redirect(url_for('library_admin'))
-        item_type = 'book'
 
     # Only check for images if not duplicating and no duplicate images provided and no book cover
     # For library mode, skip this check as images come only from ISBN fetch
@@ -6047,7 +6069,8 @@ def upload_item():
             parent_item_id=parent_item_id,
             isbn=item_isbn,
             item_type=item_type,
-            library_category=library_category
+            library_category=library_category,
+            is_library=item_is_library
         )
         if not item_id:
             break

Web/modules/database/items.py

@@ -24,7 +24,7 @@ import Web.modules.database.settings as cfg
 from Web.modules.database.settings import MongoClient
 
 
-LIBRARY_ITEM_TYPES = ('book', 'cd', 'dvd', 'media', 'schulbuch')
+LIBRARY_ITEM_TYPES = ('book', 'cd', 'dvd', 'other', 'schoolbook', 'Buch', 'Schulbuch', 'schulbuch')
 
 
 def _non_library_query(extra_query=None):
@@ -49,7 +49,7 @@ def add_item(name, ort, beschreibung, images=None, filter=None, filter2=None, fi
              ansch_jahr=None, ansch_kost=None, code_4=None, reservierbar=True,
              series_group_id=None, series_count=1, series_position=1,
              is_grouped_sub_item=False, parent_item_id=None,
-             isbn=None, item_type='general', library_category=None):
+             isbn=None, item_type='general', library_category=None, is_library=False):
     """
     Add a new item to the inventory.
     
@@ -102,6 +102,7 @@ def add_item(name, ort, beschreibung, images=None, filter=None, filter2=None, fi
             'ISBN': isbn,
             'library_category': library_category,
             'ItemType': item_type,
+            'is_library': is_library, 
             'SeriesGroupId': series_group_id,
             'SeriesCount': series_count,
             'SeriesPosition': series_position,

Web/modules/inventarsystem/excel_export.py

@@ -37,20 +37,23 @@ def generate_library_excel(items):
             item.get("ReturnDate", ""),
             item.get("Anschaffungskosten", "")
         ]
-        ws.append(row)
         
-    for col in ws.columns:
+        # FIX: Clean the row data INSIDE the loop for every single item
-        max_length = 0
+        clean_row = []
-        column = col[0].column_letter 
+        for value in row:
-        for cell in col:
+            if isinstance(value, list):
-            try:
+                # Converts ['A', 'B'] to "A, B" and an empty list [] to an empty string ""
-                if len(str(cell.value)) > max_length:
+                clean_row.append(", ".join(map(str, value)) if value else "")
-                    max_length = len(str(cell.value))
+            elif isinstance(value, dict):
-            except:
+                # Just in case there is an embedded MongoDB sub-document
-                pass
+                clean_row.append(str(value))
-        ws.column_dimensions[column].width = min(max_length + 2, 50)
+            else:
+                clean_row.append(value)
+        
+        # Append the safe, flattened row to the worksheet
+        ws.append(clean_row)
 
     excel_buffer = io.BytesIO()
     wb.save(excel_buffer)
     excel_buffer.seek(0)
-    return excel_buffer
+    return excel_buffer

Web/templates/library_table.html

@@ -4,6 +4,57 @@
 
 {% block content %}
 <style>
+    /* The Dark Background Overlay */
+    .modal {
+        position: fixed;
+        top: 0;
+        left: 0;
+        width: 100vw;
+        height: 100vh;
+        background-color: rgba(0, 0, 0, 0.6);
+        /* Display is managed by JS (none/flex) */
+        align-items: center; 
+        justify-content: center;
+        z-index: 1000;
+    }
+
+    /* The White Modal Box */
+    .modal-content {
+        background-color: #fff;
+        padding: 20px;
+        width: 80%;
+        max-width: 600px;
+        border-radius: 8px;
+        box-shadow: 0 4px 15px rgba(0, 0, 0, 0.2);
+
+        /* Flexbox allows the header to stay fixed while the body scrolls */
+        display: flex;
+        flex-direction: column;
+        max-height: 85vh;
+    }
+
+    /* The Close Button */
+    .close {
+        align-self: flex-end;
+        color: #aaa;
+        font-size: 28px;
+        font-weight: bold;
+        cursor: pointer;
+        line-height: 1;
+        margin-bottom: 10px;
+    }
+
+    .close:hover,
+    .close:focus {
+        color: #000;
+        text-decoration: none;
+    }
+
+    /* The Scrollable Content Area */
+    #detailContent {
+        overflow-y: auto; /* Adds scrollbar only if needed */
+        padding-right: 10px; /* Prevents text from rubbing against the scrollbar */
+    }
     /* Library table-only view styles */
     .library-table-container {
         max-width: 1400px;
@@ -475,7 +526,7 @@
                 <select id="filterType">
                     <option value="">-- Alle Typen --</option>
                     <option value="book">Buch</option>
-                    <option value="schulbuch">Schulbuch</option>
+                    <option value="schoolbook">Schulbuch</option>
                     <option value="cd">CD</option>
                     <option value="dvd">DVD</option>
                     <option value="other">Sonstige</option>
@@ -503,6 +554,10 @@
                 <svg width="20" height="20" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M14 2H6a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V8z"></path><polyline points="14 2 14 8 20 8"></polyline><line x1="8" y1="13" x2="16" y2="13"></line><line x1="8" y1="17" x2="16" y2="17"></line><polyline points="10 9 9 9 8 9"></polyline></svg>
                 Alle ausgeliehen Excel
             </button>
+            <button class="button" style="background: #10b981; color: white; display: flex; align-items: center; gap: 0.5rem;" onclick="window.location.href='/library/export/all_books'">
+                <svg width="20" height="20" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M14 2H6a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V8z"></path><polyline points="14 2 14 8 20 8"></polyline><line x1="8" y1="13" x2="16" y2="13"></line><line x1="8" y1="17" x2="16" y2="17"></line><polyline points="10 9 9 9 8 9"></polyline></svg>
+                Alle Bücher Excel
+            </button>
         </div>
     </div>
 
@@ -536,15 +591,14 @@
     </div>
 </div>
 
-<!-- Detail Modal -->
+<script src="https://cdnjs.cloudflare.com/ajax/libs/dompurify/3.0.6/purify.min.js"></script>
+
 <div id="detailModal" class="modal" style="display: none;">
     <div class="modal-content">
         <span class="close" onclick="closeDetailModal()">&times;</span>
         <div id="detailContent"></div>
     </div>
 </div>
-
-<script src="https://cdn.jsdelivr.net/npm/@ericblade/quagga2/dist/quagga.js"></script>
 <script src="https://cdn.jsdelivr.net/npm/@ericblade/quagga2/dist/quagga.js"></script>
 <script>
     // =========================================================================
@@ -1033,7 +1087,7 @@
     }
 
     function getItemTypeLabel(type) {
-        const labels = { 'book': 'Buch', 'cd': 'CD', 'dvd': 'DVD', 'other': 'Sonstige' };
+        const labels = { 'book': 'Buch', 'cd': 'CD', 'dvd': 'DVD', 'other': 'Sonstige', 'schoolbook': 'Schulbuch' };
         return labels[type] || type;
     }
 
@@ -1043,20 +1097,47 @@
         return div.innerHTML;
     }
 
+    // Opens the modal and fetches the data
     function showItemDetail(itemId) {
+        const detailContent = document.getElementById('detailContent');
+        const detailModal = document.getElementById('detailModal');
+
+        // 1. Show the loading state immediately
+        detailContent.innerHTML = '<p>Loading details...</p>';
+        detailModal.style.display = 'flex';
+
+        // 2. Fetch the data
         fetch(`/api/item_detail/${itemId}`)
-            .then(r => r.text())
+            .then(response => {
-            .then(html => {
+                if (!response.ok) {
-                document.getElementById('detailContent').innerHTML = html;
+                    throw new Error(`HTTP error! status: ${response.status}`);
-                document.getElementById('detailModal').style.display = 'flex';
+                }
+                return response.text();
             })
-            .catch(err => console.error('Error loading detail:', err));
+            .then(html => {
+                // 3. Clean the HTML and display it
+                detailContent.innerHTML = DOMPurify.sanitize(html);
+            })
+            .catch(err => {
+                console.error('Error loading detail:', err);
+                detailContent.innerHTML = '<p>Sorry, we could not load the item details. Please try again later.</p>';
+            });
     }
 
+    // Closes the modal via the 'x' button
     function closeDetailModal() {
         document.getElementById('detailModal').style.display = 'none';
     }
 
+    // Closes the modal if the user clicks the dark background overlay
+    window.onclick = function(event) {
+        const modal = document.getElementById('detailModal');
+        // If the click happened directly on the dark overlay (not the white box)
+        if (event.target === modal) {
+            closeDetailModal();
+        }
+    };
+
     // =========================================================================
     // 5. EVENT LISTENERS INITIALIZATION & ON-LOAD INITIALIZER
     // =========================================================================
@@ -1336,10 +1417,10 @@
                     <label for="editLibraryType">Medientyp</label>
                     <select id="editLibraryType" style="width: 100%;">
                         <option value="book">Buch</option>
-                        <option value="schulbuch">Schulbuch</option>
+                        <option value="schoolbook">Schulbuch</option>
                         <option value="cd">CD</option>
                         <option value="dvd">DVD</option>
-                        <option value="media">Sonstige Medien</option>
+                        <option value="other">Sonstige Medien</option>
                     </select>
                 </div>
                 <div>

update.sh

@@ -621,6 +621,9 @@ EOF
     cleanup_old_dist_artifacts
     cleanup_docker_dangling_images
     log_message "Update completed successfully to release $latest_tag"
+
+    sudo ./opt/Inventarsystem/restart.sh
+    echo "Restart of the Server Completet"
 }
 
 main "$@"