Auto-generate VAPID keys upon startup using py-vapid, and add pywebpush to requirements, drop obsolete script

.gitignore

@@ -4,4 +4,6 @@ certs
 build
 .venv
 __pycache__
-.pyc
+.pycvapid.json
+Web/vapid.json
+Web/vapid_*.pem

Web/push_notifications.py

@@ -16,11 +16,39 @@ import settings as cfg
 
 logger = logging.getLogger(__name__)
 
-# VAPID keys for push notifications (should be in environment variables)
+# VAPID keys for push notifications
 VAPID_PUBLIC_KEY = os.getenv('VAPID_PUBLIC_KEY', '')
 VAPID_PRIVATE_KEY = os.getenv('VAPID_PRIVATE_KEY', '')
 VAPID_SUBJECT = os.getenv('VAPID_SUBJECT', f'mailto:admin@{os.getenv("SERVER_NAME", "localhost")}')
 
+VAPID_PRIVATE_PEM = os.path.join(os.path.dirname(__file__), 'vapid_private.pem')
+VAPID_PUBLIC_PEM = os.path.join(os.path.dirname(__file__), 'vapid_public.pem')
+
+# Auto-generate VAPID keys if none are provided
+if not VAPID_PUBLIC_KEY or not VAPID_PRIVATE_KEY:
+    try:
+        from py_vapid import Vapid, b64urlencode
+        from cryptography.hazmat.primitives import serialization
+        
+        vapid = Vapid()
+        if not os.path.exists(VAPID_PRIVATE_PEM):
+            vapid.generate_keys()
+            vapid.save_key(VAPID_PRIVATE_PEM)
+            vapid.save_public_key(VAPID_PUBLIC_PEM)
+            logger.info("Auto-generated new VAPID keys")
+        else:
+            vapid = Vapid.from_file(VAPID_PRIVATE_PEM)
+            
+        raw_pub = vapid.public_key.public_bytes(
+            serialization.Encoding.X962,
+            serialization.PublicFormat.UncompressedPoint
+        )
+        
+        VAPID_PUBLIC_KEY = b64urlencode(raw_pub)
+        VAPID_PRIVATE_KEY = VAPID_PRIVATE_PEM
+    except Exception as e:
+        logger.error(f'Could not load or generate VAPID keys: {e}')
+
 # Push service endpoint (typically Firebase or Web Push Service)
 PUSH_SERVICE_URL = 'https://fcm.googleapis.com/fcm/send'  # Firebase Cloud Messaging
 FCM_API_KEY = os.getenv('FCM_API_KEY', '')  # Firebase API key

Web/requirements.txt

@@ -13,4 +13,4 @@ redis
 reportlab
 python-barcode
 openpyxl
-cryptography
+cryptographypywebpush

Web/templates/base.html

@@ -1754,27 +1754,7 @@
     <script src="{{ url_for('static', filename='js/mobile_compatibility.js') }}"></script>
     <script src="{{ url_for('static', filename='js/ios_fixes.js') }}"></script>
     
-    <!-- Service Worker Registration for Push Notifications -->
-    <script>
-        document.addEventListener('DOMContentLoaded', function() {
-            // Register service worker for push notifications and offline support
-            if ('serviceWorker' in navigator) {
-                navigator.serviceWorker.register('{{ url_for("static", filename="service-worker.js") }}')
-                    .then(function(registration) {
-                        console.log('Service Worker registered successfully:', registration);
-                        
-                        // Check if we have permission for push notifications
-                        if ('Notification' in window && Notification.permission === 'granted') {
-                            console.log('Push notifications already enabled');
-                        }
-                    })
-                    .catch(function(error) {
-                        console.warn('Service Worker registration failed:', error);
-                    });
-            } else {
-                console.log('Service Workers not supported in this browser');
-            }
-        });
-    </script>
+    <!-- Push Notifications Script -->
+    <script src="{{ url_for('static', filename='js/push-notifications.js') }}"></script>
 </body>
 </html>

Web/templates/notifications.html

@@ -14,6 +14,8 @@
     </form>
   </div>
 
+  <div id="push-notification-settings" style="margin-bottom: 24px;"></div>
+
   <div style="display:grid; grid-template-columns:1fr; gap:14px;">
     <section style="background:#fff; border:1px solid #e2e8f0; border-radius:14px; padding:16px;">
       <h2 style="margin:0 0 12px; font-size:1.15rem;">Meine Benachrichtigungen</h2>
@@ -83,4 +85,12 @@
     {% endif %}
   </div>
 </div>
+
+<script>
+document.addEventListener('DOMContentLoaded', function() {
+    if (typeof showPushNotificationSettings === 'function') {
+        showPushNotificationSettings();
+    }
+});
+</script>
 {% endblock %}

generate-vapid-keys.sh

@@ -1,81 +0,0 @@
-#!/bin/bash
-
-# VAPID Key Generation Script for Web Push Notifications
-# Generates VAPID (Voluntary Application Server Identification) keys required for push notifications
-
-echo "==========================================="
-echo "VAPID Key Generation for Inventarsystem"
-echo "==========================================="
-echo ""
-
-# Check if Python is available
-if ! command -v python3 &> /dev/null; then
-    echo "❌ Error: Python 3 is required but not installed."
-    exit 1
-fi
-
-# Check if pywebpush is installed
-echo "Checking for pywebpush..."
-python3 -c "import pywebpush" 2>/dev/null
-
-if [ $? -ne 0 ]; then
-    echo "Installing pywebpush..."
-    pip3 install pywebpush
-    if [ $? -ne 0 ]; then
-        echo "❌ Error: Failed to install pywebpush"
-        echo "Please install manually: pip3 install pywebpush"
-        exit 1
-    fi
-fi
-
-echo "✓ pywebpush is installed"
-echo ""
-
-# Generate VAPID keys
-echo "Generating VAPID keys..."
-python3 << 'EOF'
-from pywebpush import generate_keys
-
-try:
-    keys = generate_keys()
-    print("✓ VAPID Keys generated successfully!")
-    print("")
-    print("PUBLIC KEY (share with browsers):")
-    print(keys['public_key'])
-    print("")
-    print("PRIVATE KEY (keep secret!):")
-    print(keys['private_key'])
-    print("")
-    print("==========================================="
-    print("Add these to your environment variables:")
-    print("==========================================="
-    print("")
-    print("export VAPID_PUBLIC_KEY='" + keys['public_key'] + "'")
-    print("export VAPID_PRIVATE_KEY='" + keys['private_key'] + "'")
-    print("export VAPID_SUBJECT='mailto:admin@yourdomain.com'")
-    print("")
-    print("Or add to your .env file:")
-    print("")
-    print("VAPID_PUBLIC_KEY=" + keys['public_key'])
-    print("VAPID_PRIVATE_KEY=" + keys['private_key'])
-    print("VAPID_SUBJECT=mailto:admin@yourdomain.com")
-    print("")
-    print("⚠️  IMPORTANT: Keep the PRIVATE KEY secret!")
-    print("==========================================="
-    
-except Exception as e:
-    print(f"❌ Error generating VAPID keys: {e}")
-    exit(1)
-EOF
-
-if [ $? -eq 0 ]; then
-    echo ""
-    echo "✓ Next steps:"
-    echo "1. Copy the PUBLIC KEY to your browser-side code"
-    echo "2. Set the PRIVATE KEY in your server environment"
-    echo "3. Update config.json with your email address"
-    echo "4. Test with: curl http://localhost:5000/api/push/vapid-key"
-else
-    echo "❌ Error generating keys"
-    exit 1
-fi

requirements.txt

@@ -13,4 +13,4 @@ reportlab
 python-barcode
 openpyxl
 cryptography
-pywebpush
+pywebpushpywebpush