changes to the student Name Processing

Web/app.py

@@ -4349,10 +4349,14 @@ def api_library_scan_action():
 
             due_date = now + datetime.timedelta(days=borrow_duration_days)
 
-            it.update_item_status(item_id, False, borrower_name)
+            app.logger.info(f"Library scan action: borrowing item {item_id} for student card {student_card_id} until {due_date.isoformat()}")
             borrower_user = us.get_user_by_student_card(student_card_id)
+            app.logger.info(f"Found borrower user: {borrower_user}")
             if not borrower_user or not borrower_user.get('_id'):
+                app.logger.warning(f"No user found for student card {student_card_id}. Cannot record borrowing in ausleihungen.")
                 return jsonify({'ok': False, 'message': 'Kein Benutzer für diesen Schülerausweis gefunden.'}), 404
+            
+            it.update_item_status(item_id, False, borrower_name)
             au.add_ausleihung(
                 item_id,
                 str(borrower_user['_id']),
@@ -4367,7 +4371,7 @@ def api_library_scan_action():
                     'channel': 'library_scan',
                     'item_id': item_id,
                     'item_name': item_doc.get('Name', ''),
-                    'borrower':borrower_name,
+                    'borrower': borrower_name,
                     'student_card_id': student_card_id,
                     'borrow_duration_days': borrow_duration_days,
                 }
@@ -4457,6 +4461,7 @@ def api_item_detail(item_id):
         db = client[MONGODB_DB]
         ausleihungen_col = db['ausleihungen']
         items_col = db['items']
+        student_cards_col = db['student_cards']
 
         # Determine parent/group id (if this is a child, use its ParentItemId)
         parent_id = str(item.get('ParentItemId') or str(item.get('_id')))
@@ -4493,16 +4498,25 @@ def api_item_detail(item_id):
         else:
             status_label = 'Verfügbar'
 
+        # Helper function to get borrower display name
+        def get_borrower_name(user_raw):
+            if not user_raw:
+                return ''
+            try:
+                user_doc = student_cards_col.find_one({'_id': ObjectId(user_raw)})
+                if user_doc:
+                    if user_doc.get('SchülerName'):
+                        return decrypt_text(str(user_doc.get('SchülerName', '')))
+                    return str(user_doc.get('AusweisId', ''))
+            except Exception:
+                pass
+            return str(user_raw)
+
         # Prefer the most recent active borrower across the group
         borrower_value = ''
         for rec in borrow_records:
             if rec.get('Status') == 'active' and rec.get('User'):
-                try:
-                    user_raw = rec.get('User')
-                    if user_raw is not None:
-                        borrower_value = decrypt_text(str(user_raw))
-                except Exception:
-                    borrower_value = str(rec.get('User', ''))
+                borrower_value = get_borrower_name(rec.get('User'))
                 break
         
         if not borrower_value and item.get('User'):
@@ -4525,17 +4539,13 @@ def api_item_detail(item_id):
             rows = []
             
             for rec in borrow_records[:3]:
-                user_raw = rec.get('User')
-                try:
-                    user = decrypt_text(user_raw) if user_raw is not None else ''
-                except Exception:
-                    user = user_raw
+                rec_borrower_name = get_borrower_name(rec.get('User')) or '-'
                 status = rec.get('Status', '')
                 start = fmt_dt(rec.get('Start'))
                 end = fmt_dt(rec.get('End'))
                 notes = html.escape(str(rec.get('Notes') or ''))
                 rows.append(
-                    f"<li><strong>{html.escape(str(user or '-'))}</strong> — "
+                    f"<li><strong>{html.escape(rec_borrower_name)}</strong> — "
                     f"{html.escape(str(status))} — "
                     f"{html.escape(str(start))} → {html.escape(str(end))}"
                     f"{(' — ' + notes) if notes else ''}</li>"

Web/modules/database/user.py

@@ -697,7 +697,7 @@ def get_user_by_student_card(student_card_id):
     client = MongoClient(cfg.MONGODB_HOST, cfg.MONGODB_PORT)
     db = _get_tenant_db(client)
     users = db['student_cards']
-    found_user = users.find_one({'SchülerName': normalized})
+    found_user = users.find_one({'AusweisId': normalized})
     client.close()
 
     # Do not call dp.decrypt_text() here because found_user is a MongoDB dictionary.